Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nx #54

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Remove nx #54

merged 3 commits into from
Jul 12, 2023

Conversation

balzdur
Copy link
Collaborator

@balzdur balzdur commented Jul 11, 2023 •
edited
Loading

Remove nx in favour of a npm workspace.

Major changes :

  • /libs & /apps are merged and flatten under /packages
  • no more code generation using Nx generators
  • task runner is now operated using npm (via npm scripts)

Caveats :

  • All dependencies are installed "globally" (= root of the workspace) for now (not blocking, it just may ship more node_modules to production)
  • Miss documentation (coming in a second PR, after everything is merged and up to date)

@balzdur balzdur marked this pull request as ready for review July 12, 2023 11:53
@balzdur balzdur enabled auto-merge July 12, 2023 11:54
Pascal-Delange
Pascal-Delange approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@Pascal-Delange Pascal-Delange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 blind approve

@balzdur balzdur merged commit 7646abc into main Jul 12, 2023
1 check passed
@balzdur balzdur deleted the remove-nx branch July 12, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pascal-Delange Pascal-Delange Pascal-Delange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balzdur @Pascal-Delange